Skip to content

Conversation

@Shelacula
Copy link

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7274

Purpose

First timer issue! Increases the comment preview length on the creations and spamban pages. It now shows 994 characters instead of 94.

Credit

Shel (she/her)

@Bilka2
Copy link
Contributor

Bilka2 commented Jan 22, 2026

Hi, Shel!

Thank you so much for this pull request, someone will be along to review it soon.

I've also updated the Jira issue status to In Review so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to [email protected] with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

@Shelacula
Copy link
Author

@Bilka2 I went ahead and made a Jira account, the name is also Shel and my email is [email protected]. Thank you!

@Bilka2
Copy link
Contributor

Bilka2 commented Jan 22, 2026

I sent you an invite that should give you the permissions automatically, please let us know if you have any issues signing up!

Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just 1 small thing

</dt>
<dd>
<%= truncate(comment.comment_content, length: 100, separator: ' ') %>
<%= truncate(comment.comment_content, length: 1000, separator: ' ') %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the reviewdog/ERB lint issue? It should be just the following:

Suggested change
<%= truncate(comment.comment_content, length: 1000, separator: ' ') %>
<%= truncate(comment.comment_content, length: 1000, separator: " ") %>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants