-
Notifications
You must be signed in to change notification settings - Fork 669
AO3-7274 Increase comment preview character limit #5556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi, Shel! Thank you so much for this pull request, someone will be along to review it soon. I've also updated the Jira issue status to In Review so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to [email protected] with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
|
@Bilka2 I went ahead and made a Jira account, the name is also Shel and my email is [email protected]. Thank you! |
|
I sent you an invite that should give you the permissions automatically, please let us know if you have any issues signing up! |
brianjaustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just 1 small thing
| </dt> | ||
| <dd> | ||
| <%= truncate(comment.comment_content, length: 100, separator: ' ') %> | ||
| <%= truncate(comment.comment_content, length: 1000, separator: ' ') %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve the reviewdog/ERB lint issue? It should be just the following:
| <%= truncate(comment.comment_content, length: 1000, separator: ' ') %> | |
| <%= truncate(comment.comment_content, length: 1000, separator: " ") %> |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7274
Purpose
First timer issue! Increases the comment preview length on the creations and spamban pages. It now shows 994 characters instead of 94.
Credit
Shel (she/her)