AO3-7210 I18n skins-creating.html help file #5554
Open
+288
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunternet93
commented
Jan 21, 2026
Contributor
Author
|
Styling: When in a modal, the skins-creating page is in a context where rules like |
Contributor
that's a problem with all new help pages (and not the only problem either), i think the ad&t are still deciding what to do about it, so you don't need to do anything right now. i'm expecting there will be a new issue or several in the future for this |
Bilka2
changed the title
Bilka2
requested changes
Jan 26, 2026
Contributor
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
Thanks for working on this complicated file!
| # | ||
| # *** IMPORTANT: if you edit these values please also update the | ||
| # skins-creating.html file in public/help *** | ||
| # skins-creating.html.erb file in app/views/help *** |
Contributor
There was a problem hiding this comment.
Suggested change
| # skins-creating.html.erb file in app/views/help *** | |
| # skins_creating.html.erb file in app/views/help *** |
| icon: Upload a preview (png, jpeg or gif) | ||
| public: Apply to make public | ||
| skin_type: Type | ||
| skins_creating_help_title: Creating skins |
Contributor
There was a problem hiding this comment.
Suggested change
| skins_creating_help_title: Creating skins | |
| skins_creating_help_title: Skins creating |
To match the current site
Comment on lines
+9
to
+11
| <p><code>background, border, column, cue, flex, font, layer-background, | ||
| layout-grid, list-style, margin, marker, outline, overflow, padding, | ||
| page-break, pause, scrollbar, text, transform, transition</code></p> |
Contributor
There was a problem hiding this comment.
indentation/formatting fix:
Suggested change
| <p><code>background, border, column, cue, flex, font, layer-background, | |
| layout-grid, list-style, margin, marker, outline, overflow, padding, | |
| page-break, pause, scrollbar, text, transform, transition</code></p> | |
| <p> | |
| <code> | |
| background, border, column, cue, flex, font, layer-background, | |
| layout-grid, list-style, margin, marker, outline, overflow, padding, | |
| page-break, pause, scrollbar, text, transform, transition | |
| </code> | |
| </p> |
Comment on lines
+15
to
+50
| <p><code>-replace, -use-link-source, accelerator, accent-color, align-content, | ||
| align-items, align-self, alignment-adjust, alignment-baseline, | ||
| appearance, azimuth, baseline-shift, behavior, binding, bookmark-label, | ||
| bookmark-level, bookmark-target, bottom, box-align, box-direction, | ||
| box-flex, box-flex-group, box-lines, box-orient, box-pack, box-shadow, | ||
| box-sizing, caption-side, clear, clip, color, color-profile, | ||
| color-scheme, content, counter-increment, counter-reset, crop, cue, | ||
| cue-after, cue-before, cursor, direction, display, dominant-baseline, | ||
| drop-initial-after-adjust, drop-initial-after-align, | ||
| drop-initial-before-adjust, drop-initial-before-align, | ||
| drop-initial-size, drop-initial-value, elevation, empty-cells, filter, | ||
| fit, fit-position, float, float-offset, font, font-effect, | ||
| font-emphasize, font-emphasize-position, font-emphasize-style, | ||
| font-family, font-size, font-size-adjust, font-smooth, font-stretch, | ||
| font-style, font-variant, font-weight, grid-columns, grid-rows, | ||
| hanging-punctuation, height, hyphenate-after, hyphenate-before, | ||
| hyphenate-character, hyphenate-lines, hyphenate-resource, hyphens, | ||
| icon, image-orientation, image-resolution, ime-mode, include-source, | ||
| inline-box-align, justify-content, layout-flow, left, letter-spacing, | ||
| line-break, line-height, line-stacking, line-stacking-ruby, | ||
| line-stacking-shift, line-stacking-strategy, mark, mark-after, | ||
| mark-before, marks, marquee-direction, marquee-play-count, | ||
| marquee-speed, marquee-style, max-height, max-width, min-height, | ||
| min-width, move-to, nav-down, nav-index, nav-left, nav-right, nav-up, | ||
| opacity, order, orphans, page, page-policy, phonemes, pitch, | ||
| pitch-range, play-during, position, presentation-level, | ||
| punctuation-trim, quotes, rendering-intent, resize, rest, rest-after, | ||
| rest-before, richness, right, rotation, rotation-point, ruby-align, | ||
| ruby-overhang, ruby-position, ruby-span, size, speak, speak-header, | ||
| speak-numeral, speak-punctuation, speech-rate, stress, string-set, | ||
| tab-side, table-layout, target, target-name, target-new, | ||
| target-position, top, unicode-bibi, unicode-bidi, user-select, | ||
| vertical-align, visibility, voice-balance, voice-duration, | ||
| voice-family, voice-pitch, voice-pitch-range, voice-rate, voice-stress, | ||
| voice-volume, volume, white-space, white-space-collapse, widows, width, | ||
| word-break, word-spacing, word-wrap, writing-mode, z-index</code></p> |
Contributor
There was a problem hiding this comment.
indentation/formatting fix:
Suggested change
| <p><code>-replace, -use-link-source, accelerator, accent-color, align-content, | |
| align-items, align-self, alignment-adjust, alignment-baseline, | |
| appearance, azimuth, baseline-shift, behavior, binding, bookmark-label, | |
| bookmark-level, bookmark-target, bottom, box-align, box-direction, | |
| box-flex, box-flex-group, box-lines, box-orient, box-pack, box-shadow, | |
| box-sizing, caption-side, clear, clip, color, color-profile, | |
| color-scheme, content, counter-increment, counter-reset, crop, cue, | |
| cue-after, cue-before, cursor, direction, display, dominant-baseline, | |
| drop-initial-after-adjust, drop-initial-after-align, | |
| drop-initial-before-adjust, drop-initial-before-align, | |
| drop-initial-size, drop-initial-value, elevation, empty-cells, filter, | |
| fit, fit-position, float, float-offset, font, font-effect, | |
| font-emphasize, font-emphasize-position, font-emphasize-style, | |
| font-family, font-size, font-size-adjust, font-smooth, font-stretch, | |
| font-style, font-variant, font-weight, grid-columns, grid-rows, | |
| hanging-punctuation, height, hyphenate-after, hyphenate-before, | |
| hyphenate-character, hyphenate-lines, hyphenate-resource, hyphens, | |
| icon, image-orientation, image-resolution, ime-mode, include-source, | |
| inline-box-align, justify-content, layout-flow, left, letter-spacing, | |
| line-break, line-height, line-stacking, line-stacking-ruby, | |
| line-stacking-shift, line-stacking-strategy, mark, mark-after, | |
| mark-before, marks, marquee-direction, marquee-play-count, | |
| marquee-speed, marquee-style, max-height, max-width, min-height, | |
| min-width, move-to, nav-down, nav-index, nav-left, nav-right, nav-up, | |
| opacity, order, orphans, page, page-policy, phonemes, pitch, | |
| pitch-range, play-during, position, presentation-level, | |
| punctuation-trim, quotes, rendering-intent, resize, rest, rest-after, | |
| rest-before, richness, right, rotation, rotation-point, ruby-align, | |
| ruby-overhang, ruby-position, ruby-span, size, speak, speak-header, | |
| speak-numeral, speak-punctuation, speech-rate, stress, string-set, | |
| tab-side, table-layout, target, target-name, target-new, | |
| target-position, top, unicode-bibi, unicode-bidi, user-select, | |
| vertical-align, visibility, voice-balance, voice-duration, | |
| voice-family, voice-pitch, voice-pitch-range, voice-rate, voice-stress, | |
| voice-volume, volume, white-space, white-space-collapse, widows, width, | |
| word-break, word-spacing, word-wrap, writing-mode, z-index</code></p> | |
| <p> | |
| <code> | |
| -replace, -use-link-source, accelerator, accent-color, align-content, | |
| align-items, align-self, alignment-adjust, alignment-baseline, | |
| appearance, azimuth, baseline-shift, behavior, binding, bookmark-label, | |
| bookmark-level, bookmark-target, bottom, box-align, box-direction, | |
| box-flex, box-flex-group, box-lines, box-orient, box-pack, box-shadow, | |
| box-sizing, caption-side, clear, clip, color, color-profile, | |
| color-scheme, content, counter-increment, counter-reset, crop, cue, | |
| cue-after, cue-before, cursor, direction, display, dominant-baseline, | |
| drop-initial-after-adjust, drop-initial-after-align, | |
| drop-initial-before-adjust, drop-initial-before-align, | |
| drop-initial-size, drop-initial-value, elevation, empty-cells, filter, | |
| fit, fit-position, float, float-offset, font, font-effect, | |
| font-emphasize, font-emphasize-position, font-emphasize-style, | |
| font-family, font-size, font-size-adjust, font-smooth, font-stretch, | |
| font-style, font-variant, font-weight, grid-columns, grid-rows, | |
| hanging-punctuation, height, hyphenate-after, hyphenate-before, | |
| hyphenate-character, hyphenate-lines, hyphenate-resource, hyphens, icon, | |
| image-orientation, image-resolution, ime-mode, include-source, | |
| inline-box-align, justify-content, layout-flow, left, letter-spacing, | |
| line-break, line-height, line-stacking, line-stacking-ruby, | |
| line-stacking-shift, line-stacking-strategy, mark, mark-after, | |
| mark-before, marks, marquee-direction, marquee-play-count, | |
| marquee-speed, marquee-style, max-height, max-width, min-height, | |
| min-width, move-to, nav-down, nav-index, nav-left, nav-right, nav-up, | |
| opacity, order, orphans, page, page-policy, phonemes, pitch, | |
| pitch-range, play-during, position, presentation-level, | |
| punctuation-trim, quotes, rendering-intent, resize, rest, rest-after, | |
| rest-before, richness, right, rotation, rotation-point, ruby-align, | |
| ruby-overhang, ruby-position, ruby-span, size, speak, speak-header, | |
| speak-numeral, speak-punctuation, speech-rate, stress, string-set, | |
| tab-side, table-layout, target, target-name, target-new, | |
| target-position, top, unicode-bibi, unicode-bidi, user-select, | |
| vertical-align, visibility, voice-balance, voice-duration, voice-family, | |
| voice-pitch, voice-pitch-range, voice-rate, voice-stress, voice-volume, | |
| volume, white-space, white-space-collapse, widows, width, word-break, | |
| word-spacing, word-wrap, writing-mode, z-index | |
| </code> | |
| </p> |
| ".font_family.description.separate_properties_html", | ||
| font_code: tag.code("font") | ||
| ) %> | ||
| <code>font-size: 1.1em; font-weight: bold; font-family: Cambria, Constantia, Palatino, Georgia, serif;</code></p> |
Contributor
There was a problem hiding this comment.
I think these should not be separate, but instead part of separate_properties_html, similar to what you did with font_code: tag.code("font").
| t(".numeric_values.description.various_units"), | ||
| "https://w3schools.com/css/css_units.asp" | ||
| ) | ||
| ) %><br /><code>cm, em, ex, in, mm, pc, pt, px</code></p> |
Contributor
There was a problem hiding this comment.
I think this list should be entirely in the locale file, since we need to be able to localise the comma, as it's a sentence, not CSS. And language like Chinese use a different comma character. Ideally this should be part of the precision_html string, if possible
| <p><%= t( | ||
| ".scale.description_html", | ||
| transform_code: tag.code("transform"), | ||
| scale_numeric_value_code: tag.code("scale(#{t('.scale.numeric_value')})") |
Contributor
There was a problem hiding this comment.
I'm wondering whether it would be better to have the entire scale(numeric value) be in the locale file, not just numeric value. But I can't really come up with a reason for it other than this looking quite strange, which isn't enough of a reason to make you change it
| <dd> | ||
| <p><%= t( | ||
| ".css_basics.description.line_of_css_html", | ||
| example_css_code: tag.code("selector {property: value;}") |
Contributor
There was a problem hiding this comment.
I think all of selector {property: value;} should be in the locale file, since we also allow to translate them below in the text that references them, and they're not set names like the CSS property names
| selector_bold: tag.strong(t(".css_basics.description.selector")), | ||
| body_tag_code: tag.code("body"), | ||
| h1_tag_code: tag.code("h1"), | ||
| property_bold: tag.strong("property"), |
Contributor
There was a problem hiding this comment.
property should be translatable
| <dd> | ||
| <p><%= t( | ||
| ".one_declaration_per_ruleset.description_html", | ||
| repeated_declarations_css_code: tag.code(tag.pre(%{ |
Bilka2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7210
Purpose
Migrates the static
skins-creating.htmlhelp file to a localized view on the help controller.