-
Notifications
You must be signed in to change notification settings - Fork 669
AO3-4031 Draft deletion notice added to multi chapter drafts #5553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This adds the top of the page warning about the draft soon being deleted to drafts with multiple chapters.
marcus8448
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! In accordance with our coding standards, could you also add an automated integration test to check for the notice on a chapter?
I also see that the three notices are identical between works and chapters. If you're up to it, it would be nice to put the notices together in a partial so that they can be shared. This is beyond the scope of the original issue, so feel free to just add a test and I'll open up a separate ticket for the partial.
|
I just added the test, and I don't know how partials work, so you can just open a new ticket for it. |
features/works/work_drafts.feature
Outdated
| Then I should see "This chapter is a draft and hasn't been posted yet!" | ||
| And I should see "Sorry, you can't comment on a draft." | ||
|
|
||
| Scenario: Creating a multichapter draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "A user should see a deletion warning message on a multichapter draft" or something similar, just so that the focus is on the warning being there.
… on multichapter drafts
|
Does that look good? |
marcus8448
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, looks great! Thanks again for contributing!
Issue
https://otwarchive.atlassian.net/browse/AO3-4031
Purpose
This adds the top of the page warning about the draft soon being deleted to drafts with multiple chapters. Before this change, there was a bug where only single chapter drafts would display the message.
Testing Instructions
Credit
FlyingFalcon they/them