Skip to content

Conversation

@lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Dec 4, 2025

@lpettyjo lpettyjo added this to the Planned for 4.21 GA milestone Dec 4, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2025
Copy link

@dfajmon dfajmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes since TP

Parameter Definition and Update Behavior

Customers must verify supported parameters with their storage provider and SHOULD explicitly declare all parameters in every VolumeAttributesClass (VAC) definition.

WARNING

Updating a PVC to use a different VAC functions as a patch operation, not a replacement. If the new VAC does not define a specific parameter that existed in the previous VAC, the PVC retains the old value. To prevent unintended configuration inheritance, ensure the target VAC includes all parameters found in the source VAC.

New Metric: Parameter Mismatch

A new metric, openshift_cluster_storage_vac_mismatch_parameters, helps identify inconsistent parameter sets that could lead to the persistence issues described above.

0: All VACs define the same set of parameters.

1: Mismatch detected. At least one VAC defines a different set of parameters than the others.

Update Frequency & Delays

While users can modify the VAC on a PVC at any time, rapid, successive updates to the same volume may trigger a cooldown period.

If a VAC is changed multiple times in a short duration, the underlying storage provider may enforce a delay. This can result in a wait time of several hours before the most recent VAC change is fully reconciled on the disk.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2026
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Jan 5, 2026

PTAL @dfajmon I've addressed your comments. Thanks!

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2026

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfajmon
Copy link

dfajmon commented Jan 7, 2026

Nicely written!
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.21 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants