ReplaceWeekYearWithYear should not replace valid week-year usages

[tginsberg]

What's changed?

This is a failing test case against issue #800

What's your motivation?

• Closes ReplaceWeekYearWithYear incorrectly replaces valid week-year usages #800

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Great to see, thanks! Sharing the notes you left on the commit here as well to make those easier to find:

• When w (week in year) is detected and we are not inside quotes, abandon replacement and return the original input.
• Also simplified replaceY, which had a redundant else-if branch.

[timtebeek]

Thanks for the help here @tginsberg ; Nice simplification & bug fix. Guess this was the best week of the year for discovery & fix. All the best there!

[tginsberg]

Thanks for making contributing so easy @timtebeek! I was writing a blog post on week year and was covering how to fix it and noticed this aspect of the rule. I figured it was a good chance to contribute, in a small way, to a project I admire so much. Thanks for accepting my fix! :)

[timtebeek]

Thanks for the kind words & help! Linking your post here for others interested as well:

• https://todd.ginsberg.com/post/java/beware-of-week-year/

We'll put out a new release in the coming days that contains your fix.