Add test case for Spring Boot 4 properties

[der-eismann]

What's changed?

• Added a test case for ChangeSpringPropertyKey not keeping YAML format #852

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Copying the failure here

diff --git a/project/src/main/resources/file.yaml b/project/src/main/resources/file.yaml
index c4f3ac8..87d3246 100644
--- a/project/src/main/resources/file.yaml
+++ b/project/src/main/resources/file.yaml
@@ -1,11 +1,10 @@ 
+
 server:
   port: 1234
 
 spring:
   datasource:
     url: jdbc:postgresql://localhost/test
-  servlet:
-    encoding:
-      charset: UTF-8
-      enabled: true
-      force: true
\ No newline at end of file
+spring.servlet.encoding.charset: UTF-8
+spring.servlet.encoding.enabled: true
+spring.servlet.encoding.force: true
\ No newline at end of file

[timtebeek]

Since the recipe we use here leverages MergeYaml underneath the proper fix is probably in openrewrite/rewrite.

[der-eismann]

Since the recipe we use here leverages MergeYaml underneath the proper fix is probably in openrewrite/rewrite.

Thanks for the assessment! I'll see if I can create a testcase for MergeYaml then. YAML parsing and editing seems to be no easy task 🙂

[der-eismann]

Hey @timtebeek, after looking at the YAML ChangePropertyKey recipe it explicitly says:

Expects dot notation for nested YAML mappings, similar to how Spring Boot interprets application.yml files.

And example 4 even shows the behavior described here, so maybe this is intended? Then I guess the only solution would be to get openrewrite/rewrite#6358 working.

[timtebeek]

Ah yes then getting unfolding to work is your best way forward; any reason you're sticking to four spaces?

• UnfoldProperties not working as expected with 4 space indentation rewrite#6358

[der-eismann]

No specific reason, I would change it to 2 spaces, unfortunately org.openrewrite.yaml.format.Indents can't change it, so we'd need to get another tool to change this, or do you have another suggestion?

[timtebeek]

Thanks for the clarification; then let's instead focus on fixing this upstream, and close this effort since there's no associated fix here.

• UnfoldProperties not working as expected with 4 space indentation rewrite#6358