Skip to content

Conversation

@nuclearkevin
Copy link
Contributor

Description

This PR adds tally support for fission heating (kappa-fission) in the random ray solver. This includes additions to the automagic multi-group cross section setup to generate heating cross sections. A new test has been added to hit the changes (random_ray_auto_convert_kappa_fission).

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@nuclearkevin nuclearkevin requested a review from jtramm as a code owner January 8, 2026 22:07
@nuclearkevin
Copy link
Contributor Author

It seems as if the test failures are caused by gcovr failing to generate C++ coverage. I don't think this has anything to do with the changes here (#3702 seems to be running into the same issue). If anyone could provide advice on getting gcovr to cooperate it would be greatly appreciated!

@paulromano
Copy link
Contributor

@nuclearkevin I have two PRs (#3715 and #3716), one or both of which should resolve the gcovr issue. Please wait on one of those to be merged; at that point, retriggering the CI here should pass since it always uses a merge commit with develop (i.e., you don't need to update your branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants