-
Notifications
You must be signed in to change notification settings - Fork 834
Add E2E conformance test for BroadcastJob uncordon handling #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @GautamBytes! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
+ Coverage 44.94% 44.96% +0.01%
==========================================
Files 318 318
Lines 32256 32260 +4
==========================================
+ Hits 14499 14507 +8
+ Misses 16333 16330 -3
+ Partials 1424 1423 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: GautamBytes <[email protected]>
ca07514 to
e567bef
Compare
Signed-off-by: GautamBytes <[email protected]>
|
@furykerry PTAL! |
|
@GautamBytes: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ⅰ. Describe what this PR does
This change enhances the existing BroadcastJob end‑to‑end test suite by adding a new conformance test that verifies the controller correctly recreates pods when a cordoned node is subsequently uncordoned.
types.StrategicMergePatchTypefor patch operations.KruiseDescribe/ConformanceItblock named "BroadcastJob uncordon handling".exit 0in the container command to avoid manual status‐patch races.Ⅱ. Does this pull request fix one issue?
fixes #1233
Ⅲ. Describe how to verify it
Ensure you have a Kubernetes cluster available for testing.
Check out this branch and run the full E2E suite:
go test ./test/e2e/... -timeout=20mConfirm that all tests, including the new
BroadcastJob uncordon handlingconformance test, pass successfully.Ⅳ. Special notes for reviews
Check out this branch and run the full E2E suite:
go test ./test/e2e/... -timeout=20m