adding pugi parsing Options to ofXml (OF enum version) #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi all, I think this pull request is good (I add it manually to each OF download), change request from your side is impelmented also. have a good day! |
fix regeression (wrongly resolved conflict)
dasoe
commented
Dec 4, 2025
Author
dasoe
left a comment
dasoe
left a comment
There was a problem hiding this comment.
Adjusted slightly as ofXml evolved.
Genreally still the same. Think it's good.
Syntax error fix. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
this is a re-opened pull request after change requests from your side.
pugi offers parsing options like "pugi::parse_default | pugi::parse_comments" in case one wants comments not to be stripped etc. Added a variable, a setter and (as requested) OF-like enum decleration to be able to use them in ofXml.
Would be used like this:
XML.setParsingOptions( OF_PARSE_DEFAULT | OF_PARSE_COMMENTS ); XML.load(pathToXML);
Hope I got this enum-thing done appropriately?
Thanks for your awesome work!
oe