Skip to content

Conversation

@jribbink
Copy link
Contributor

@jribbink jribbink commented Jan 6, 2026

Closes #2244

Description

This new syntax is recognized for flow emulator --fork mainnet-fork:

"networks": {
    "mainnet": {
        "mainnet-fork": {
            "host": "127.0.0.1:3569",
            "fork": "mainnet"
        }
    }
}

This PR adds the missing piece preventing the following syntax from being recognized in the flow test command.

The test framework forking guides/usage are currently advising users to use the syntax flow test --fork mainnet which can potentially be too rigid for complex testing scenarios divergent from mainnet (the original idea behind introducing custom networks).


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Jan 6, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jribbink jribbink merged commit 36a03aa into master Jan 7, 2026
9 checks passed
@jribbink jribbink deleted the jribbink/fix-fork-res branch January 7, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify forking network naming across Test Framework & Emulator

4 participants