fix(issues): redesign how to launch issue checkers #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced the `IssueChecker` class to unify tag validation and provider issue checks. - Updated `EditorController` and `IssuesPanelController` to delegate issue checking to `IssueChecker`. - Simplified and modularized issue collection logic for better maintainability. Signed-off-by: Hiroshi Miura <[email protected]>
- Added unit tests for `IssueChecker` to validate aggregation of tag and provider issues. - Verified file pattern-based filtering of issues. - Implemented testing for duplicate issue filtering logic. Signed-off-by: Hiroshi Miura <[email protected]>
- Replaced fully qualified `java.util.Optional` with a direct `Optional` import for cleaner code. Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
…nization - Moved issue checking logic to a dedicated `checkIssuesOnLeave` method. - Extracted source synchronization into `synchronizeTeam` method for better readability. - Refactored identical source handling into `findAllIdenticalSources` method. Signed-off-by: Hiroshi Miura <[email protected]>
…arity - Renamed `StubProject` to `TestingProject` for better clarity. - Replaced inline `TestProvider` implementation with `TestingIssueProvider`. - Updated `setUp` method to use `setUpClass` and simplified state setup. - Cleaned up imports and improved Javadoc formatting. Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
- Migrated issue providers registry to `CoreState` for better test isolation and modularity. - Updated `IssueProviders` API methods to delegate to `CoreState` registry. - Introduced `ensureDefaultsInstalled` for maintaining default providers order and avoiding duplicates. - Added registry reset in `TestCoreState` to ensure test consistency. Signed-off-by: Hiroshi Miura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is workbench to refactor issue checker and redesign core feature.
Pull request type
Which ticket is resolved?
What does this PR change?
Other information