zavan - Technical Training #1131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
plha-odoo
reviewed
Jan 19, 2026
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
good job, for the commit title and message, you can (for the next commits) follow these guidelines https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html
Imported the right modules and fixed some typos. The estate_property table now shows up in PostgresSQL :D
MAGREMENT
changed the title
added 2 commits
January 20, 2026 08:28
Fixed typo for in acces rights file
Made the basic menus, added the Properties action and edited the properties
plha-odoo
reviewed
Jan 20, 2026
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
Good job for the commit titles and the general quality of the code.
just a nitpick:
We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline.
added 2 commits
January 20, 2026 10:58
Created the list, form & search views
Added all the models & the links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.