Skip to content

Conversation

@amahm-odoo
Copy link

No description provided.

@amahm-odoo amahm-odoo requested a review from artn-odoo January 19, 2026 15:18
@robodoo
Copy link

robodoo commented Jan 19, 2026

Pull request status dashboard

Copy link

@artn-odoo artn-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job so far !
Just some small styling nitpicks, otherwise it's all good.
We try to always put a new line at the end of a file, this can be done automatically when you save your file in vscode if the Insert Final Newline option is activated.

'name': 'Estate',
'version': '1.9',
'category': 'Real Estate',
'summary' : 'Manage your real estate properties',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwanted white space here

Suggested change
'summary' : 'Manage your real estate properties',
'summary': 'Manage your real estate properties',

Comment on lines 4 to 7
_name = 'estate.property'
_description = 'Estate Property'
name = fields.Char(string='Name', required=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to put the new line between the private attributes and the fields instead

Suggested change
_name = 'estate.property'
_description = 'Estate Property'
name = fields.Char(string='Name', required=True)
_name = 'estate.property'
_description = 'Estate Property'
name = fields.Char(string='Name', required=True)

@artn-odoo artn-odoo requested a review from csan-odoo January 21, 2026 08:57
Copy link

@csan-odoo csan-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few minor nitpicks

Add SQL constraints to ensure prices are positive and names are unique. Implement a Python constraint to prevent selling prices below 90% of the expected price.
Implement several UI improvements to enhance user experience and data visibility:
- Add state-based decorations (color/bold) to the property and offer list views.
- Add inline buttons to the offer list for quick 'Accept' and 'Refuse' actions.
- Implement a stat button on the property type form to display a count of related offers.
- Enhance the property form with statusbar, ribbons, and color-coded tags.
- Update search views with custom filter domains and default groupings.
Create a new link module 'estate_account' that depends on 'estate' and 'account'.

Implement model inheritance for 'estate.property' to override 'action_sold':
- Automatically create an 'account.move' (Customer Invoice) for the property buyer.
- Add two invoice lines using the Command namespace:
    1. Commission: 6% of the property selling price.
    2. Administrative fees: Fixed amount of 100.00.
Create a kanban view with name, selling price, expected price, best price and tag ids and group them by type id
@amahm-odoo amahm-odoo changed the title adding real estate module [ADD] estate : add real estate module Jan 22, 2026
Copy link

@csan-odoo csan-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Just make sure to follow the guidelines for the commit title :)

Copy link

@csan-odoo csan-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a couple of quick changes needed.

Comment on lines +20 to +26
<record id="estate_property_offer_action" model="ir.actions.act_window">
<field name="name">Offers</field>
<field name="res_model">estate.property.offer</field>
<field name="view_mode">list,form</field>
<field name="domain">[('property_type_id', '=', active_id)]</field>
<field name="view_ids" eval="[(5, 0, 0), (0, 0, {'view_mode': 'list', 'view_id': ref('estate_property_offer_view_tree_stat')})]"/>
</record>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain better organization and consistency, all views related to a specific model should be kept together in the same XML file. Therefore, this code would be more appropriately placed in estate_property_offer_views.xml.

Comment on lines +4 to +18
<record id="estate_property_offer_view_tree_stat" model="ir.ui.view">
<field name="name">estate.property.offer.list.stat</field>
<field name="model">estate.property.offer</field>
<field name="arch" type="xml">
<list string="Property Offers" editable="bottom"
decoration-danger="status == 'refused'"
decoration-success="status == 'accepted'">
<field name="property_id"/>
<field name="price"/>
<field name="partner_id"/>
<field name="validity"/>
<field name="date_deadline"/>
</list>
</field>
</record>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<record id="estate_property_offer_view_tree_stat" model="ir.ui.view">
<field name="name">estate.property.offer.list.stat</field>
<field name="model">estate.property.offer</field>
<field name="arch" type="xml">
<list string="Property Offers" editable="bottom"
decoration-danger="status == 'refused'"
decoration-success="status == 'accepted'">
<field name="property_id"/>
<field name="price"/>
<field name="partner_id"/>
<field name="validity"/>
<field name="date_deadline"/>
</list>
</field>
</record>

"author": "Odoo",
"license": "LGPL-3",
"depends": ["estate", "account"],
"data": [],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"data": [],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants