Estate module declaration and models #1126
Conversation
|
|
artn-odoo
left a comment
artn-odoo
left a comment
There was a problem hiding this comment.
Good job so far, just a few styling nitpicks but it's good overall !
We try to always add a newline at the end of a file. This can be done by activating the Insert Final Newline if you are using vscode.
Also, we have pretty strict guidelines regarding the commit titles and message. You can find them here for future commits https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html
estate/__manifest__.py
Outdated
| 'version':'1.0', | ||
| 'summary':'Track advertisements added for real estate and allow selling them', | ||
| 'website':'https://www.odoo.com/app/estate', | ||
| 'depends':[ | ||
| 'base' | ||
| ], | ||
| 'application':True, | ||
| 'installable':True, | ||
| 'author':'moali', | ||
| 'license':'LGPL-3' |
There was a problem hiding this comment.
Try to leave a white space after :
| 'version':'1.0', | |
| 'summary':'Track advertisements added for real estate and allow selling them', | |
| 'website':'https://www.odoo.com/app/estate', | |
| 'depends':[ | |
| 'base' | |
| ], | |
| 'application':True, | |
| 'installable':True, | |
| 'author':'moali', | |
| 'license':'LGPL-3' | |
| 'version':' 1.0', | |
| 'summary': 'Track advertisements added for real estate and allow selling them', | |
| 'website': 'https://www.odoo.com/app/estate', | |
| 'depends': [ | |
| 'base' | |
| ], | |
| 'application': True, | |
| 'installable': True, | |
| 'author': 'moali', | |
| 'license': 'LGPL-3' |
estate/models/estate_property.py
Outdated
| _name = 'estate_property' | ||
| _description = 'Estate Property' | ||
|
|
||
| name = fields.Char(string = "Property Name", required = True) |
There was a problem hiding this comment.
We try not to put white spaces around the = sign in function calls or function definitions.
The same can be said for all the fields below.
| name = fields.Char(string = "Property Name", required = True) | |
| name = fields.Char(string="Property Name", required=True) |
|
I have created a new commit with the formatted code |
3 participants
No description provided.