ibrha - first commit #1121
Open
ibrha - first commit #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This module provides managing real estate advertisements. It introduces the \`estate.property\` model with fields for: - Property descriptions (name, description, postcode, etc.) - Pricing (expected and selling price) - Physical characteristics (bedrooms, living area, facades) - Garden information (area and orientation)
plha-odoo
reviewed
Jan 21, 2026
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
Good job for these first chapters and for using the proper git title convention !
a few small comments :
- We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline. - the convention is to have two blank lines before a class definition
adds the initial UI for the estate module: - Add action and menus in XML files. - Add new fields and modify the existing fields. - Update manifest to include the new XML files.
Adds multiple ui views (list, form, search) 1) adding missing EOLs 2) updating fields in estate.property model
plha-odoo
reviewed
Jan 22, 2026
plha-odoo
left a comment
plha-odoo
left a comment
There was a problem hiding this comment.
great job on the code, the commit titles and most of the styling.
A few comments :
- on your last commit title, the convention is to always write the name of the module in lower case.
- a few styling mistake written in the Style runbot
HazemWaheed2050
force-pushed
the
19.0-technical-training-ibrha
branch
from
dcdf605 to
d05cf91
Compare
- Define 'estate.property.offer' and 'estate.property.tag' and 'estate.property.type' models. - Add One2many relationship for offers and Many2many for tags, types on properties. - Update property views with a notebook containing 'Offers' and 'Other Info' tabs. - Add 'salesman' and 'buyer' fields to properties other info's section.
HazemWaheed2050
force-pushed
the
19.0-technical-training-ibrha
branch
from
d05cf91 to
be45f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.