19.0 tutorials kukor #1103

kukor-odoo · 2026-01-01T10:18:23Z

No description provided.

1. Architecture Overview 2. A New Application

Fixed the white space error, added a space after the colon ( : ). { 'name': 'Real Estate', 'author': 'Kunj Koradiya', 'description': 'This is the description' } Added space after each colon.

Added the line after the end of the code { 'name': 'Real Estate', 'author': 'Kunj Koradiya', 'description': 'This is the description' } Added a new line at the end.

Fixed the white space error, which was at the end of the line in the description 'description': 'This is the description' Removed the space from the end of the line

Fixed the license error, which later added at the last 'license': 'LGPL-3' Added the license

robodoo · 2026-01-01T10:18:27Z

-Added the initial estate property model with basic fields. -Configured access rights via ir.model.access.csv to enable CRUD operation. -Introduced menu items to expose the model in the UI. -Created custom list, form, and search views to replace default generic views. -Improved usability by defining proper field layouts and search filters. Completed Chapter 3-6

-Removed the unwanted imports from the estate_property.py Completed chapter 3-6

- Added property types, tags, and offers models with views - Linked properties with buyer, salesperson, types, tags, and offers - Displayed offers and relations in property views Completed the Chapter 7

- Fixed the line Spacing in the __init__.py file Completed the Chapter 7

mash-odoo

Hello @kukor-odoo,
Nice start for the module.
Please apply the suggested changes wherever necessary.

estate/models/estate_property.py

estate/models/estate_property_offer.py

estate/views/estate_property_views.xml

- Updated naming conventions for models and views - Cleaned up imports, spacing, and unnecessary attributes - Aligned selection fields and filters with Odoo standards

- Removed the comma buyer_id = fields.Many2one('res.users')

Add a computed field `best_price` on `estate.property`, calculated from the highest offer price (using `@api.depends`). Also implement an `@api.onchange` on the `garden` field to set default values for `garden_area` and `garden_orientation`. Completed Chapter 8

- Replaced inconsistent use of single and double quotes across Python files. - Fixed quote usage in the manifest file to align with coding standards.

- Added server actions and buttons to manage property state transitions - Implemented logic to accept/refuse offers and mark properties as sold - Added SQL constraints to ensure valid and consistent data - Added Python constraints to enforce business rules on pricing Completed Chapters 9 and 10

mash-odoo

Hello,
I am getting this traceback, can you please resolve it?
Also, please update your PR title and description.

estate/views/estate_property_offers.xml

estate/models/estate_property.py

estate/views/estate_property_views.xml

- Resolved the traceback issue in the estate module. - Removed the unnecessary property_id field from the offer form, as it is not required.

- Improve estate views following the Sprinkles tutorial. - Add list decorations, inline editing, and statusbar widgets. - Apply deterministic ordering and sequence handling. - Enhance overall UI clarity and usability.

- Implement maintenance tracking with title, cost, and status fields. - Prevent property sale when maintenance requests are pending and calculate total maintenance costs.

mash-odoo

Hello,
Good going on this task..
Please go through my questions and suggestions

estate/models/estate_property.py

estate/models/estate_property_offer.py

mash-odoo · 2026-01-09T13:27:32Z

estate/models/estate_property_offer.py

+    )
+    property_type_id = fields.Many2one(
+        related='property_id.property_type_id', store=True)
+    check_button = fields.Char(store=False)


Is there a need to add store=False here, also why is it a Char field?

I used store=False because I didn’t want the field to be stored in the database—it was only needed temporarily for some logic that would change later. Initially, the field was a Boolean, but I later changed it to a Char field.

The reason check_button is a Char field is that I needed to pass a string value from it to the XML file. I switched from Boolean to Char so I could pass a string instead and observe the change, but I didn’t notice any difference.

estate/models/estate_property_type.py

estate/views/estate_property_offers.xml

estate/views/estate_property_views.xml

estate/views/estate_type_views.xml

- Applied the requested review changes to the estate module. - Improved the offer acceptance flow and updated related property behavior. - Adjusted views and field options to better match the expected workflow. - Overall, the module now follows the reviewed structure and logic.

- Add recordset operations, domain filtering, and computed fields following the Sprinkles chapter. - Extend existing models using proper inheritance and method overrides. - Introduce a new module with models, views, and access rights, and integrate it with the estate app. Completed Chapters 11, 12, and 13

kukor-odoo added 5 commits January 1, 2026 10:22

[ADD] estate : Chapter 1 and Chapter 2 Complete

8002616

1. Architecture Overview 2. A New Application

[FIX] estate : Fix the white space error

efebb63

Fixed the white space error, added a space after the colon ( : ). { 'name': 'Real Estate', 'author': 'Kunj Koradiya', 'description': 'This is the description' } Added space after each colon.

[FIX] estate : Fix the new line error

8195d59

Added the line after the end of the code { 'name': 'Real Estate', 'author': 'Kunj Koradiya', 'description': 'This is the description' } Added a new line at the end.

[FIX] estate : Fix the white space at the end of the line

cef554a

Fixed the white space error, which was at the end of the line in the description 'description': 'This is the description' Removed the space from the end of the line

[FIX] estate : Fix the error for the License

4da8fef

Fixed the license error, which later added at the last 'license': 'LGPL-3' Added the license

kukor-odoo added 4 commits January 1, 2026 18:28

[FIX] estate: removed the unwanted imports.

a0d35f0

-Removed the unwanted imports from the estate_property.py Completed chapter 3-6

[ADD] estate: implement model relations (types, tags, offers)

4959a87

- Added property types, tags, and offers models with views - Linked properties with buyer, salesperson, types, tags, and offers - Displayed offers and relations in property views Completed the Chapter 7

[FIX] estate: fix the line spacing

1f59426

- Fixed the line Spacing in the __init__.py file Completed the Chapter 7

mash-odoo requested changes Jan 2, 2026

View reviewed changes

kukor-odoo added 5 commits January 4, 2026 10:56

[FIX] estate: fixed review comments

476d061

- Updated naming conventions for models and views - Cleaned up imports, spacing, and unnecessary attributes - Aligned selection fields and filters with Odoo standards

[FIX] estate: fixed trailing comma

f2a3d2a

- Removed the comma buyer_id = fields.Many2one('res.users')

[FIX] estate: fixed the single and double quotes

c5bae2e

- Replaced inconsistent use of single and double quotes across Python files. - Fixed quote usage in the manifest file to align with coding standards.

mash-odoo requested changes Jan 7, 2026

View reviewed changes

[FIX] estate: fix traceback and clean up offer form

7dde16c

- Resolved the traceback issue in the estate module. - Removed the unnecessary property_id field from the offer form, as it is not required.

kukor-odoo force-pushed the 19.0-tutorials-kukor branch from 543fb53 to 7dde16c Compare January 9, 2026 05:45

[ADD] estate: enhance views and UI behavior

bb1dd37

- Improve estate views following the Sprinkles tutorial. - Add list decorations, inline editing, and statusbar widgets. - Apply deterministic ordering and sequence handling. - Enhance overall UI clarity and usability.

kukor-odoo force-pushed the 19.0-tutorials-kukor branch from cf9976a to bb1dd37 Compare January 9, 2026 13:18

[ADD] estate: Add property maintenance request management

2ab5de2

- Implement maintenance tracking with title, cost, and status fields. - Prevent property sale when maintenance requests are pending and calculate total maintenance costs.

kukor-odoo force-pushed the 19.0-tutorials-kukor branch from de376d5 to 2ab5de2 Compare January 12, 2026 09:25

mash-odoo requested changes Jan 13, 2026

View reviewed changes

kukor-odoo force-pushed the 19.0-tutorials-kukor branch 5 times, most recently from 4ed62d3 to 7b321f5 Compare January 19, 2026 07:28

kukor-odoo force-pushed the 19.0-tutorials-kukor branch from 7b321f5 to 2aae513 Compare January 19, 2026 08:36

kukor-odoo force-pushed the 19.0-tutorials-kukor branch from 2aae513 to 54dcff3 Compare January 19, 2026 08:42

19.0 tutorials kukor #1103

Are you sure you want to change the base?

19.0 tutorials kukor #1103

Uh oh!

Conversation

kukor-odoo commented Jan 1, 2026

Uh oh!

robodoo commented Jan 1, 2026

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mash-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mash-odoo Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

kukor-odoo Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mash-odoo left a comment •

edited

Loading