-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: remove volta from install options #8492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
745987f to
bac6492
Compare
|
I removed the translation changes as asked by the bot. |
|
:rip: Volta |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8492 +/- ##
=======================================
Coverage 73.70% 73.70%
=======================================
Files 108 108
Lines 9210 9200 -10
Branches 313 312 -1
=======================================
- Hits 6788 6781 -7
+ Misses 2420 2417 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
mikeesto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming it could also be removed from:
Description
After 8 years of faithful and reliable service, Volta is no longer maintained. Consequently, this PR removes Volta from the recommended installation methods. o7
Validation
Check that Volta is not in the dropdown list anymore on the
/en/downloadRelated Issues
None
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.