Skip to content

build: add --shared-gtest configure flag #61279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: add --shared-gtest configure flag #61279

aduh95 wants to merge 1 commit into from
+66 −23

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 5, 2026

googletest is listed as dependency of libnode, it seems useful to support getting it as a shared lib.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2026

Review requested:

  • @nodejs/actions
  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jan 5, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 5, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70681/

@codecov
Copy link

codecov bot commented Jan 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.00%. Comparing base (6218d14) to head (af31789).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61279      +/-   ##
==========================================
- Coverage   88.01%   88.00%   -0.02%     
==========================================
  Files         704      704              
  Lines      208759   208759              
  Branches    40194    40196       +2     
==========================================
- Hits       183741   183709      -32     
- Misses      16958    17004      +46     
+ Partials     8060     8046      -14

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 5, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70684/

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95 @nodejs-github-bot @cjihrig @legendecas @marco-ippolito @avivkeller