process: improve process.cwd() error message

[Tseian]

Issue

#57045

Description

Improves the error message when process.cwd() failed by adding prefix err message 'process.cwd failed with error' if call uv_cwd failed

Before

Error: ENOENT: no such file or directory, uv_cwd

After

ENOENT: process.cwd failed with error no such file or directory, the current working directory was likely removed without changing the working directory, uv_cwd

Changes

• src/node_process_methods.cc

Test

• test/known_issues/test-cwd-enoent-file.js
• test/parallel/test-cwd-enoent-improved-message.js

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (05d6b9b) to head (752b571).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61164   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         703      703           
  Lines      208599   208605    +6     
  Branches    40229    40229           
=======================================
+ Hits       184685   184695   +10     
+ Misses      15939    15935    -4     
  Partials     7975     7975           

Files with missing lines	Coverage Δ
src/node_process_methods.cc	88.84% <100.00%> (+0.14%)	⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Tseian]

@theanarkh @joyeecheung Please trigger the ci to check again.

[Tseian]

@joyeecheung @legendecas @Qard @theanarkh Pls code review this pr

[Qard]

My thinking with reporting the issue initially was that we could provide a bit more expanded context explaining what the cause could be, like stating that the current working directory was likely removed without changing the working directory to something else. It's already I think obvious enough that the error is coming from a cwd() call. What's not obvious is why.

[Tseian]

My thinking with reporting the issue initially was that we could provide a bit more expanded context explaining what the cause could be, like stating that the current working directory was likely removed without changing the working directory to something else. It's already I think obvious enough that the error is coming from a cwd() call. What's not obvious is why.

@Qard So, would changing the error message to "ENOENT: process.cwd failed with error no such file or directory, the current working directory was likely removed without changing the working directory, uv_cwd" achieve it?

[Qard]

That sounds reasonable to me. 🙂

[Tseian]

That sounds reasonable to me. 🙂

Got it. I will commit it soon.

[Tseian]

@Qard Hi, I have committed it. Please have a code review for it, and if there is no issue please trigger the CI to check again.

[Tseian]

@Qard If you have time, please help trigger a CI to check and review the pr. Thank you very much😊.

[github-actions]

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - process: improve process.cwd() error message
   ⚠  - process: add notice message when process.cwd() failed.
   ⚠  - process: fix cpp format issue
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20535988465

[Tseian]

@Qard Sorry to bother you again. The CI checks for the cpp format failed. My bad. I have fixed the issue. Could you please trigger the CI to check and CR again?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70612/

[Tseian]

@addaleax It is confusing that the three ci actions are pending in running status for 2 days. Could you please help to trigger it again?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70629/