NVME support #3355
Open
NVME support #3355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @drake7707 Thanks for the PR ! Is anyone with a Smart driver and a non NVME disk can test the PR ? |
Author
I managed to find an USB adapter that supports SMART data for a SATA drive and hooked it up to my server, mapped it through to the docker glances container and i'm getting: 
Which I assume is correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue #2916, by using pySMART instead of the old pySMART-smartx the nvme attributes can also be fetched
Someone is going to need to test if this impacts existing drives, it shouldn't but i don't have an hdd in my server.
Resume