use vary and initial_value from NXparameters in NXfit_function
#1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspie
changed the title
vary and initial_value from NXparameters in NXfit_function
mkuehbach
added a commit
to rayosborn/definitions
that referenced
this pull request
Nov 10, 2025
mkuehbach
reviewed
Nov 10, 2025
Contributor
There was a problem hiding this comment.
If #1560 will be accepted, the attributes initial, min, max, vary do not need to be defined here in NXfit_function, they are inherited from NXparameters
Contributor
Author
|
Closed in favor of #1560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This align
NXparametersused inNXfit_functionwith the changes to the base classNXparametersapplied in #1560.I couldn’t make my PR point to @rayosborn's branch because it is on his own private repository, so I just pointed it to the main branch. Not sure if the whole thing needs a vote, as it is basically just clean-up.