-
Notifications
You must be signed in to change notification settings - Fork 65
SECoP: sample environments #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Regarding the fruitful discussion in the meeting on the 16.07., it was suggested that additional options 'humidity', 'viscosity', and 'concentration' could be applied to the NXsensor/measurement field with the attribute 'custom=True' according to the current NXsensor definition (without explicitly defining them) and, additionally, could be defined by a reference to an external resource (e.g. a PURL of an ontology term), see #1569. Following this approach, I wonder if all requirements of SECoP in this issue could be solved this way, i.e. by referencing an external knowledge representation. For example, adding the custom field 'humidity' to NXsample with a reference to the QUDT ontology (https://qudt.org/vocab/quantitykind/RelativeHumidity). For this reason, I would suggest to wait with this PR and see if #1569 can be solved. |
|
To record other comments from the meeting on July 16:
|
|
As a note: The NXsensor/meaning field of NeXus is represented in SECoP by the 'function' (https://sampleenvironment.github.io/secop-site/specification/descriptive.html#optional-module-properties). |
This PR solves issues #1315, #1329, #1342, #1365, #1571 and replaces PR #1330 and #1328. Moreover, #1326 and #1327, respectively, are redundant since SECoP agreed that having any number of NXenvironment groups in NXsample is sufficient. The reason for this PR is that jkotan, who creates most of the issues and PRs, is no longer so heavily involved in the SECoP project.
This PR implements SECoP changes that require to implement complex sample environment systems, a clear definition of the sample's state, and the sample environments defining the sample's state. Up to now this is only achieved for some sample conditions, e.g. the temperature by defining the field temperature and temperature_env in NXsample as well as the 'temperature' value in NXsensor/measurement. To achieve this on a wider level, three more optional values (humidity, viscosity, concentration) are added to NXsensor/measurement and missing CONDITION fields (including units type if required) and CONDITION_env are added to NXsample, namely:
To my understanding, this PR is just a coherent implementation of the logic that is already inherent in NeXus.