-
Notifications
You must be signed in to change notification settings - Fork 65
NXsubentry documentation updates #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add NXsample links in SAS:NXsubentry and Fluo:NXsubentry - SAS:NXsubentry/instrument/detector should point to entry/instrument/SASdet (which means don't need explicit link to entry/instrument/SASdet/data in SAS:NXsubentry/instrument/detector) - The detector links in Fluo:NXsubentry should point to the detectors in entry/instrument, not to the data within them (follow pattern of SAS:NXsubentry)
|
@gerrit-guenther: Can you comment? |
|
I'm not clear how the one line of documentation added by commit satisfies the questions raised in #1124 or #886 (comment). |
|
Ok, Ive re-read the original issue, and here are the specific questions, broken out and restated:
I've added new documentation to NXsubentry which I believe answers them.
3 and 4 are hopefully answered by 2. In addition I've noted that NXsubentries aren't designed to be contained within each other. Ok, these are at least my interpretations of what is going on. Feedback appreciated :) |
|
From code camp: I have included this note in the PR: "An NXsubentry should not contain another NXsubentry". Is that correct? @yayahjb says we shouldn't need the restriction. @PeterC-DLS says it doesn't make sense for subentries to be nested. This would open the possibility of an application specifying a subentry. (Aaron: this might be useful for workflows?) I based the assertion on my reading of the docs and @prjemian's comment showing the two use cases (with and without subentries) as meaning those are the only supported, but this might not be what was intended. @mkoennecke what is the behavior of cnxvalidate if it finds a nested subentry? Thoughts? |
Closes #1124