Safely access :request_method on bandit start events #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82a0b1e added a path in which [:bandit, :server, :start] events missing `Plug.Conn` could propagate downstream withouth the `:request_id` attribute. A dot-style accessor for `:request_method` downstream causes processes to crash, reporting the error in the New Relic Agent rather than the bandit error which caused the initial event.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
82a0b1e added a path in which [:bandit, :server, :start] events missing
Plug.Conncould propagate downstream without the:request_idattribute.A dot-style accessor for
:request_methoddownstream causes processes to crash, reporting the error from the New Relic Agent rather than the bandit error which caused the initial event.