Remove crossOrigin annotation check #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since support for annotations was removed, it was calling non-existent method
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where AccessPolicy was attempting to call a non-existent method ComponentReflection::parseAnnotation() after annotation support was removed from the framework. The change removes the obsolete annotation check for @crossOrigin, as this functionality has been fully replaced by the modern PHP 8 attribute-based approach using #[Requires(sameOrigin: false)].
- Removes call to non-existent
parseAnnotation()method that would cause runtime errors - Maintains identical security behavior through existing attribute-based check on line 70
- Aligns code with framework's migration from annotations to PHP 8 attributes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since support for annotations was removed, it was calling non-existent method.