GENKGB-452 #456
Open
GENKGB-452 #456
+538
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellasia
reviewed
Dec 19, 2025
Contributor
stellasia
left a comment
stellasia
left a comment
There was a problem hiding this comment.
Some minor comments, but look very good
| prop_name = prop.get("name", "unknown") | ||
| node_label = node_type.get("label", "unknown") | ||
|
|
||
| if isinstance(required_value, str): |
Contributor
There was a problem hiding this comment.
Here we could stringify the required_value to also cover int values for instance?
Contributor
Author
There was a problem hiding this comment.
Good catch! I'll stringify it to handle int values.
| if label and prop: | ||
| constraint_props.setdefault(label, set()).add(prop) | ||
|
|
||
| # Skop node_types without constraints |
Contributor
There was a problem hiding this comment.
Small typo
Suggested change
| # Skop node_types without constraints | |
| # Skip node_types without constraints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for extracting
requiredproperty field fromSchemaFromTextExtractor.This feature enables the LLM to identify which properties are mandatory (must exist on every node) versus optional (may be absent).
Changes:
SchemaExtractionTemplateprompt with Rule 9 (REQUIRED PROPERTIES) to guide the LLM in identifying required vs optional properties_filter_properties_required_field()method to sanitizerequiredvalues from LLM responses (handles boolean, string conversions, and invalid types)_enforce_required_for_constraint_properties()method to auto-set required: true for properties with UNIQUENESS constraints.Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):