Skip to content

[Data Grid] Prevent clear cell selection on edit mode #20544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
siriwatknp wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Data Grid] Prevent clear cell selection on edit mode #20544

siriwatknp wants to merge 4 commits into from
+58 −0

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Dec 3, 2025 •
edited
Loading

closes #20542

Please see the original issue for details

@siriwatknp siriwatknp added scope: data grid Changes related to the data grid. plan: Premium Impact at least one Premium user. feature: Editing Related to the data grid Editing feature feature: Cell Selection Related to the cell selection feature labels Dec 3, 2025
@siriwatknp siriwatknp requested review from a team and cherniavskii December 3, 2025 08:07
@siriwatknp siriwatknp added the type: bug It doesn't behave as expected. label Dec 3, 2025
@mui-bot
Copy link

mui-bot commented Dec 3, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20544--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 🔺+35B(+0.01%) 🔺+15B(+0.01%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 7477e82

@siriwatknp @sai6855
Update packages/x-data-grid-premium/src/tests/cellSelection.DataGridP…
a6b38fd 
…remium.test.tsx

Co-authored-by: sai chand <[email protected]>
Signed-off-by: Siriwat K <[email protected]>
@michelengelen
Copy link
Member

michelengelen commented Dec 8, 2025

For some reason it does not fix it fully:

  • selecting cells by dragging still removes the selection when pressing space bar
  • selecting cells by using SHIFT+click it works as expected
Screen.Recording.2025-12-08.at.10.40.47.mov

@siriwatknp
Copy link
Member Author

siriwatknp commented Dec 9, 2025

  • selecting cells by dragging still removes the selection when pressing space bar

Thanks for reporting. It's so weird that the interactions are different.

@siriwatknp
Copy link
Member Author

siriwatknp commented Dec 9, 2025

For some reason it does not fix it fully:

Fixed. added a new test to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sai6855 sai6855 sai6855 left review comments

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feature: Cell Selection Related to the cell selection feature feature: Editing Related to the data grid Editing feature plan: Premium Impact at least one Premium user. scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] type spacebar in editing mode clear cell selection

4 participants

@siriwatknp @mui-bot @michelengelen @sai6855