Avoid illegal characters in compiled method names. #2241
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This should fix part of #2239. |
rbri
reviewed
Dec 24, 2025
| result = "script"; | ||
| } | ||
| return result; | ||
| return illegalChars.matcher(result).replaceAll("_"); |
Collaborator
There was a problem hiding this comment.
Not sure how the method name construction works. But maybe this simple replacement might lead to duplicate names if the source names are only differ in invalid cars.
Contributor
Author
There was a problem hiding this comment.
Luckily they get a unique numerical component added.
Collaborator
|
OK, makes sense to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that functions names that reach the class compiler are turned into legal JVM method names.