-
Notifications
You must be signed in to change notification settings - Fork 0
Island rhythms/bug hunt mode #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
vkarpov15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Biggest suggestions:
- Move sleuth mode into a sidebar on models.html and document-details.html. You should be able to add a document to a case report directly from a list of documents or a single document.
- No more steps, e.g. no "aggregate" or "summarize". We don't really need a state machine for sleuth mode, I want to think of it more as a "notebook" where you're gathering data for future inspection.
| })) : | ||
| []; | ||
|
|
||
| const caseReport = await Sleuth.create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Sleuth Mode" is a great name for the user facing feature, but I'd prefer to keep CaseReport or something similar as the model name
| : 'text-gray-500 hover:text-ultramarine-600'" | ||
| @click="sleuthContext.goToAggregating()" | ||
| > | ||
| Step 1: Aggregating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step-by-step mode feels a bit clunky and I frequently feel like I want to go back and forth between "investigating", "aggregating", and "summarize". Collapsing these all into one would be good.
| enum: ['created', 'in_progress', 'cancelled', 'resolved', 'archived'] | ||
| }, | ||
| documents: [{ | ||
| document: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this documentId
| documents: [{ | ||
| document: { | ||
| type: mongoose.Schema.Types.ObjectId, | ||
| refPath: 'documentModel' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, this would need to be documents.documentModel. Or ref: function() { return this.documentModel }.
| default: 'created', | ||
| enum: ['created', 'in_progress', 'cancelled', 'resolved', 'archived'] | ||
| }, | ||
| documents: [{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add a "highlightedFields" property here because when you're bug hunting you're typically just looking at certain fields, and those can sometimes be buried behind other fields.
No description provided.