Skip to content

Conversation

@IslandRhythms
Copy link
Contributor

No description provided.

Copy link
Member

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biggest suggestions:

  1. Move sleuth mode into a sidebar on models.html and document-details.html. You should be able to add a document to a case report directly from a list of documents or a single document.
  2. No more steps, e.g. no "aggregate" or "summarize". We don't really need a state machine for sleuth mode, I want to think of it more as a "notebook" where you're gathering data for future inspection.

})) :
[];

const caseReport = await Sleuth.create({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Sleuth Mode" is a great name for the user facing feature, but I'd prefer to keep CaseReport or something similar as the model name

: 'text-gray-500 hover:text-ultramarine-600'"
@click="sleuthContext.goToAggregating()"
>
Step 1: Aggregating
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step-by-step mode feels a bit clunky and I frequently feel like I want to go back and forth between "investigating", "aggregating", and "summarize". Collapsing these all into one would be good.

enum: ['created', 'in_progress', 'cancelled', 'resolved', 'archived']
},
documents: [{
document: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this documentId

documents: [{
document: {
type: mongoose.Schema.Types.ObjectId,
refPath: 'documentModel'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, this would need to be documents.documentModel. Or ref: function() { return this.documentModel }.

default: 'created',
enum: ['created', 'in_progress', 'cancelled', 'resolved', 'archived']
},
documents: [{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a "highlightedFields" property here because when you're bug hunting you're typically just looking at certain fields, and those can sometimes be buried behind other fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants