Qr repo #9
Open
Qr repo #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to flush out query functionality, integrate with `test_sync` module, and integrate with CLI.
Use the decorator in remaining portions of code where appropriate.
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 77.71% 76.09% -1.63%
==========================================
Files 25 28 +3
Lines 6407 6993 +586
==========================================
+ Hits 4979 5321 +342
- Misses 1428 1672 +244
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Be smarter about syncing the JSON to disk. Handle intraprocess concurrency by making QrRepo a singleton on any given path and serializing writes through a single thread. Handle interprocess concurrency (including on NFS) with 'flufl.lock' package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add a local only non-naive data store for smallish amounts of data. Mostly leverage existing ability to serialize our QueryResult class to/from JSON.