fix: [2.6] correct index_has_raw_data logic for fielddata loading (#46117) #46155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o#46117) Related to milvus-io#46098 This fix addresses a bug where the segment loader incorrectly determined whether scalar fields have raw data in their indexes, leading to unnecessary field data loading or skipping indexed raw data retrieval. - Build `field_ids` vector that handles both single field and column group cases (when `child_fields_size() > 0`) - Move the mmap setting and index_has_raw_data checks before the skip decision, iterating over the correctly built `field_ids` - Fix the boolean AND logic in both `Load()` and `LoadColumnGroup()` to properly check if ALL fields in the group have raw data in their indexes This bug was hiding the root cause of issue milvus-io#46098, where QueryNode panics when outputting timestamptz data from scalar index with raw data. Signed-off-by: Congqi Xia <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Contributor
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #46155 +/- ##
==========================================
+ Coverage 73.58% 76.09% +2.51%
==========================================
Files 1356 1875 +519
Lines 210761 291473 +80712
==========================================
+ Hits 155079 221787 +66708
- Misses 48311 62297 +13986
- Partials 7371 7389 +18
🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #46117
Related to #46098
This fix addresses a bug where the segment loader incorrectly determined whether scalar fields have raw data in their indexes, leading to unnecessary field data loading or skipping indexed raw data retrieval.
field_idsvector that handles both single field and column group cases (whenchild_fields_size() > 0)field_idsLoad()andLoadColumnGroup()to properly check if ALL fields in the group have raw data in their indexesThis bug was hiding the root cause of issue #46098, where QueryNode panics when outputting timestamptz data from scalar index with raw data.