-
Notifications
You must be signed in to change notification settings - Fork 36.7k
70853n/272840 add hover colors #278809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
70853n/272840 add hover colors #278809
Conversation
…oft#272840) Introduces titleBar.activeHoverBackground and titleBar.activeHoverForeground variables.
- adds css styling for :hover state of the back and forward and toolbar buttons
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
|
@microsoft-github-policy-service agree |
3320858 to
b03a661
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds hover color customization for title bar actions (back/forward navigation buttons and command center) by introducing two new theme color variables: titleBar.activeHoverBackground and titleBar.activeHoverForeground. The implementation follows existing VS Code theming patterns and integrates with the color registry validation tests.
Key Changes
- Added two new theme color definitions following the existing hover state pattern
- Configured initial color values for dark and light themes
- Applied the colors in CSS to title bar action hover states
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/common/theme.ts |
Registered two new theme colors using toolbarHoverBackground and TITLE_BAR_ACTIVE_FOREGROUND as defaults, consistent with menubar selection pattern |
src/vs/workbench/services/themes/common/workbenchThemeService.ts |
Added initial color values for both dark and light themes following the existing color scheme |
src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css |
Applied hover styles to title bar action labels, though contains duplicate rule that should be removed |
build/lib/stylelint/vscode-known-variables.json |
Added CSS variable names in correct alphabetical order for stylelint validation |
Proposed changes
Fixes #272840 by introducing two theme color variables.
Testing
Automated tests
Automated test already exist under
/vscode/src/vs/workbench/contrib/themes/test/node/colorRegistry.releaseTest.tsManual testing
Steps to reproduce
Preferences: Open User Settings (JSON)BackandForwardbuttons in the title barExpected behaviour
Unless a button is
disabledit should show white text on a black background.