Skip to content

Conversation

@caohai
Copy link
Member

@caohai caohai commented Dec 17, 2025

Pull Request Template – vscode-mssql

Description

Refactor the "Open in Agent Mode" context menu command to use JSON-formatted prompts instead of comma-delimited strings. This fixes:

  • Ambiguity when server names contain commas (e.g., localhost,1433)
  • Undefined values appearing in prompts by omitting empty/undefined fields

Most models didn't have issue with the old prompt but less performant models would not be able to recover / call list connections.

Before:
image
After:
image

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5285 KB 5285 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )
data-workspace VSIX null KB 532 KB ⚪ 532 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.93%. Comparing base (2339af6) to head (eed82f7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20838      +/-   ##
==========================================
+ Coverage   65.91%   65.93%   +0.01%     
==========================================
  Files         210      210              
  Lines       19997    20004       +7     
  Branches     2600     2602       +2     
==========================================
+ Hits        13182    13189       +7     
  Misses       6718     6718              
  Partials       97       97              
Files with missing lines Coverage Δ
extensions/mssql/src/controllers/mainController.ts 17.27% <100.00%> (+0.07%) ⬆️
extensions/mssql/src/copilot/tools/toolsUtils.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@caohai caohai merged commit 9e714ff into main Dec 18, 2025
3 checks passed
@caohai caohai deleted the hacao/fix-agent-mode-prompt branch December 18, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants