Fixing schema designer and table designer profiles before init #20753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasimkhan30
requested review from
Benjin,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
PR Changes
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (56.25%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #20753 +/- ##
==========================================
- Coverage 65.84% 65.84% -0.01%
==========================================
Files 210 210
Lines 19887 19892 +5
Branches 2577 2578 +1
==========================================
+ Hits 13095 13098 +3
- Misses 6695 6697 +2
Partials 97 97
🚀 New features to boost your workflow:
|
added 6 commits
December 9, 2025 12:23
…on and connection preparation - Introduced error messages for loading Schema Designer and retry options. - Enhanced error handling in SchemaDesignerStateProvider and TableDesignerWebviewController. - Updated locConstants for new error messages.
aasimkhan30
changed the title
Benjin
previously approved these changes
Dec 10, 2025
extensions/mssql/src/reactviews/pages/SchemaDesigner/schemaDesignerPage.tsx
Outdated
Show resolved
Hide resolved
caohai
approved these changes
Dec 10, 2025
aasimkhan30
added a commit
that referenced
this pull request
Dec 10, 2025
* Adding telemetry and prepare conn profile to table designer and schema designer. * remove dup confirmTokenValidity call. * Fixing ordering * Fixing tests * Add error handling and user feedback for Schema Designer initialization and connection preparation - Introduced error messages for loading Schema Designer and retry options. - Enhanced error handling in SchemaDesignerStateProvider and TableDesignerWebviewController. - Updated locConstants for new error messages. * Fixed * Fixing rpc registration. * Fixing lint issues. * fixed name * Adding more error handling and fixng message. * Added loc * Fixing error telemetry * Made dialogs conditional. --------- Co-authored-by: Aasim Khan <[email protected]>
5 tasks
Benjin
pushed a commit
that referenced
this pull request
Dec 11, 2025
… (#20776) * Adding telemetry and prepare conn profile to table designer and schema designer. * remove dup confirmTokenValidity call. * Fixing ordering * Fixing tests * Add error handling and user feedback for Schema Designer initialization and connection preparation - Introduced error messages for loading Schema Designer and retry options. - Enhanced error handling in SchemaDesignerStateProvider and TableDesignerWebviewController. - Updated locConstants for new error messages. * Fixed * Fixing rpc registration. * Fixing lint issues. * fixed name * Adding more error handling and fixng message. * Added loc * Fixing error telemetry * Made dialogs conditional. --------- Co-authored-by: Aasim Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
Enables call stack and prepare connection profile before initializing table designer and schema designer and making sure we are handling initialization failures properly
Issue: #20763
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines