-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Support program parameter in attach configurations (#14046) #14108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Subham-KRLX
wants to merge
10
commits into
microsoft:main
Choose a base branch
from
Subham-KRLX:feature/attach-by-program-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−19
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8aeeb69
Update build.cmd
Subham-KRLX 6b7cebe
samples(Fib): remove build task, update README, remove preLaunchTask …
Subham-KRLX 81f63e2
feat: support program parameter in attach configs
Subham-KRLX 2a62420
Merge branch 'main' into feature/attach-by-program-name
Subham-KRLX d65120d
Fix: Move findProcessByProgramName method to correct class location
Subham-KRLX ca240e2
Merge branch 'main' into feature/attach-by-program-name
Subham-KRLX a894144
Merge branch 'main' into feature/attach-by-program-name
Subham-KRLX 7cc44c1
Fix: Revert unrelated Code Samples changes and remove unwanted submodule
Subham-KRLX 050503c
Fix: Thoroughly revert Code Samples changes to match upstream/main
Subham-KRLX 4046187
Fix: Address all PR review feedback from sean-mcmanus
Subham-KRLX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this check to the very beginning before "program" is checked and don't show any error? Otherwise, those users would start to get an error.