Check if maxpagesize should be reinjected #9355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Contributor
|
No changes needing a change description found. |
radhgupta
requested review from
JoshLove-msft,
christothes,
jorgerangel-msft,
jsquire and
m-nash
as code owners
...rs/TestData/RestClientProviderTests/TestNextLinkReinjectedParametersInCreateRequestMethod.cs
Outdated
Show resolved
Hide resolved
...TestData/RestClientProviderTests/TestPageSizeParameterReinjectedInCreateNextRequestMethod.cs
Outdated
Show resolved
Hide resolved
...TestData/RestClientProviderTests/TestPageSizeParameterReinjectedInCreateNextRequestMethod.cs
Outdated
Show resolved
Hide resolved
...TestData/RestClientProviderTests/TestPageSizeParameterReinjectedInCreateNextRequestMethod.cs
Outdated
Show resolved
Hide resolved
...harp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/Internal/ClientUriBuilder.cs
Show resolved
Hide resolved
...harp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/Internal/ClientUriBuilder.cs
Outdated
Show resolved
Hide resolved
...harp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/Internal/ClientUriBuilder.cs
Outdated
Show resolved
Hide resolved
...p/generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/ClientUriBuilderTests.cs
Show resolved
Hide resolved
...sharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/RestClientProvider.cs
Outdated
Show resolved
Hide resolved
...harp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/Internal/ClientUriBuilder.cs
Outdated
Show resolved
Hide resolved
...nerator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientUriBuilderDefinition.cs
Outdated
Show resolved
Hide resolved
...nerator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientUriBuilderDefinition.cs
Outdated
Show resolved
Hide resolved
jorgerangel-msft
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for appending query parameters in the generated REST client code to ensure that duplicate query parameters are not added when handling "next link" requests (typically used for pagination). The changes introduce runtime checks to prevent reinjecting parameters that are already present in the query string, and update the relevant test cases to reflect this behavior.
Fixes: #9201