-
Notifications
You must be signed in to change notification settings - Fork 3
feat(#171): add support for kubernetes deployment in EKS #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
witash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I tested in EKS and got all the services running. The domains didn't work yet, but that could be something else, I'm still looking into that.
For local setup, whats the advantage of using kind instead of k3s/k3d? If there's a good reason, that's ok, but cht-core's test and local set up uses k3s or k3d, so since would often want cht-core if developing cht-interoperabilty, it means having two different kubernetes things running locally.
| - port: 5432 | ||
| targetPort: 5432 | ||
| --- | ||
| # CouchDB for CHT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for EKS at least, couchdb and the cht deployment should be conditional, and allow an external cht to be used. Even for testing and development deployments, its common to want to deploy only the interop stack, with an cht instance deployed somewhere else (that has the data you want).
Ahh, ok! I was not aware of the local setup for CHT, just the tests. I've not tried k3s or k3d but if this works in them it does make sense to use those instead. Let me try this out. |
Description
Adds support for kubernetes deployment in EKS.
Fixes: #171
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.