-
Notifications
You must be signed in to change notification settings - Fork 3
feat(#167): Add Subscription and Feedback workflow with OpenIMIS #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(#167): Add Subscription and Feedback workflow with OpenIMIS #168
Conversation
witash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a function for creating subscriptions in utils/fhir.ts
It is used in the loss to follow up workflow, for what seems to be a similar use case.
Instead of creating new functions for OpenIMIS specifically, can we use that, or, if not, modify it to make it more generic?
That function is not reusable at all for OpenIMIS use-case but I could make the |
Yea, the idea is not to have LTFU subscription and OpenIMIS subscription and OpenMRS subscription but a single subscription that works for any fhir api. could put it in fhir.ts or maybe create another utils file if it makes sense. |
|
@witash I've refactored |
mediator/src/utils/fhir.ts
Outdated
| /** | ||
| * Interface for the Subscription Channel object. | ||
| */ | ||
| interface SubscriptionChannel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the types from the fhir module here instead of redefining them?
Description
Adds
SubscriptionofClaimresource of OpenIMIS. Also, later on added support on processing theClaimresource Provided by OpenIMIS and then, sending back the feedback data on the sameClaimresource back to OpenIMIS asCommunicationresource.#167
This PR will be in draft because the task is still in POC phase. The tests in the CI is failing as well because they are not true unit tests. They will be converted once this task takes some form of finalization.
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.