Add check for non array in field-evaluator #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| declare(strict_types=1); | ||
|
|
||
| /* |
Member
There was a problem hiding this comment.
Suggested change
| declare(strict_types=1); | |
| /* | |
| /* |
wachterjohannes
force-pushed
the
hotfix/field-evaluator
branch
from
1a6a409 to
903207e
Compare
|
|
||
| public function evaluateCondition($object, string $condition) | ||
| { | ||
| if (!\is_array($object)) { |
Member
There was a problem hiding this comment.
why the object should be an array and not an object? what is the issue you try to solve here?
The variable is called object so I think it should handle also objects not only arrays
Member
Author
There was a problem hiding this comment.
the function can be called with any type and the expression language requires an array - so returning false
wachterjohannes
force-pushed
the
hotfix/field-evaluator
branch
from
903207e to
e10c933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$this->expressionLanguage->evaluate($condition, $object);expect only a array.