feature/cancel-command #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doutriaux1
approved these changes
Nov 13, 2025
Collaborator
doutriaux1
left a comment
doutriaux1
left a comment
There was a problem hiding this comment.
Looks good. Thanks for all the added testing too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #587 so we should probably get that merged first.
This branch adds in the
merlin cancelcommand. This command does the following when given a study to cancel:So it's essentially a wrapper for the
merlin stop-workersandmerlin purgecommands, with some additional database logic.In order to accomplish this, I had to add a "status" entry to the
RunModeldata model. This status is different from the status given checked with themerlin statusandmerlin detailed-statuscommands. Those commands check step- and task-level statuses; this new "status" entry is to track the status of a full run.The
merlin monitorwill now check this new run-level status. If a run is listed as active (initialized, queued, or running) then the monitor will watch that run. If a run is listed as finished (completed, cancelled, or failed) then the monitor will not watch that run.