feature/db-garbage-collection #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arbage-collection
lucpeterson
reviewed
Oct 7, 2025
jwhite242
reviewed
Oct 13, 2025
Collaborator
jwhite242
left a comment
jwhite242
left a comment
There was a problem hiding this comment.
One more general comment: type usage in the method argument docstrings was ~inconsistent.
Member
Author
|
Thanks for the review @jwhite242. I'll go back through all of the docstrings/type hints to make sure they're accurate with the latest changes once this is done. |
feature/gc-filesys-check
jwhite242
approved these changes
Oct 22, 2025
Collaborator
jwhite242
left a comment
jwhite242
left a comment
There was a problem hiding this comment.
Thanks for addressing the cross-filesystem issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds garbage collection functionality for the database. Additionally, this garbage collection is integrated into the
merlin monitorcommand so that it's run by default. There are also some extra checks for invalid workflows that have been added to the monitor to try to make it more resilient.