Skip to content

feat(overlay): Add frame count threshold for auto-disable functionality #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliteprox merged 3 commits into from
Nov 25, 2025
Merged

feat(overlay): Add frame count threshold for auto-disable functionality #71

eliteprox merged 3 commits into from
Nov 25, 2025

Conversation

@eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Nov 25, 2025 •
edited
Loading

  • Introduced frame_count_to_disable parameter in OverlayConfig to specify the number of consecutive valid frames required before the overlay auto-disables.
  • Updated OverlayController to track consecutive received frames and conditionally disable loading based on the new threshold.

This prevents "flickering" when a pipeline is inconsistently producing output frames during warmup

        overlay_config=OverlayConfig(
            mode=OverlayMode.PROGRESSBAR,
            message="Loading...",
            enabled=True,
            auto_timeout_seconds=0.5,
            frame_count_to_disable=20,
        ),

@eliteprox
feat(overlay): Add frame count threshold for auto-disable functionality
90ffd05 
- Introduced `frame_count_to_disable` parameter in OverlayConfig to specify the number of consecutive valid frames required before the overlay auto-disables.
- Updated OverlayController to track consecutive received frames and conditionally disable loading based on the new threshold.
@eliteprox eliteprox requested a review from JJassonn69 November 25, 2025 19:01
JJassonn69
JJassonn69 approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@JJassonn69 JJassonn69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks small change, if already tested end-to-end. LGTM

@eliteprox eliteprox merged commit 08b375e into main Nov 25, 2025
1 check passed
@eliteprox eliteprox deleted the feat/frame_count_to_disable_overlay branch November 26, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JJassonn69 JJassonn69 JJassonn69 approved these changes

@ad-astra-video ad-astra-video Awaiting requested review from ad-astra-video

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliteprox @JJassonn69