Fix pts overflow in fps filter #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing some very large segments to be produced if the input had some weird characteristics like missing timestamps. Co-authored-by: Marco van Dijk <[email protected]>
j0sh
force-pushed
the
ja/large-transcoders
branch
from
334e6a0 to
e5db9ec
Compare
Contributor
|
Do you have a screen shot of this test passing? The test action is failing with a seg fault but don't think its from this test since it looks like they have been failing for a while. |
Collaborator
Author
Collaborator
Author
|
@ad-astra-video Yes something about CI is making the consecutive MP4 test fail but everything passes for me locally - broken for about a year now, see #422 |
thomshutt
approved these changes
Sep 5, 2025
j0sh
added a commit
to livepeer/go-livepeer
that referenced
this pull request
Sep 5, 2025
Needed to fix livepeer/lpms#438 The `go mod tidy` step reshuffled a few dependencies and cleaned up go.sum but no other version bumps.
j0sh
added a commit
to livepeer/go-livepeer
that referenced
this pull request
Sep 5, 2025
Needed to fix livepeer/lpms#438 The `go mod tidy` step reshuffled a few dependencies and cleaned up go.sum but no other version bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing some very large segments to be produced if the input had some weird characteristics like missing timestamps.
Alternative to #436