feat(pipeline): ensure warmup uses generated frames instead of input frames #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Reverting to draft as this is showing a regression |
eliteprox
force-pushed
the
feat/warmup-frames
branch
from
1997e11 to
bc26d67
Compare
- Added `ensure_warmup` method to the Pipeline class to manage warmup state based on resolution. - Integrated warmup checks in the ComfyStreamFrameProcessor to ensure the pipeline is ready before processing streams. - Implemented default workflow application when no prompts are provided during stream initialization. - Improved error handling for warmup failures and streamlined frame processing logic.
…rocessing to avoid blocking frame processor - Implemented methods to toggle and manage a loading overlay in the ComfyStreamFrameProcessor. - Added functionality to disable the overlay after pipeline ingest resumes. - Enhanced error handling for loading overlay state updates. - Integrated loading overlay management into the stream start process to improve user experience.
eliteprox
force-pushed
the
feat/warmup-frames
branch
from
752b28c to
e7ebed6
Compare
Collaborator
Author
|
All tests passing on this change, will deploy to staging shortly once build is available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warmup optimization to ensure pipeline consistency:
ensure_warmupmethod to the Pipeline class to manage warmup state based on resolution.ComfyStreamFrameProcessorto ensure the pipeline is ready before processing streams.This change relies on pytrickle livepeer/pytrickle#77, which adds
set_loading_overlayto the StreamProcessor to allow toggling overlay without blocking the frame processor. This is an alternative to returningVideoProcessingResult.WITHHELDLoading Overlay Changes
ComfyStreamFrameProcessor.