-
Notifications
You must be signed in to change notification settings - Fork 208
fix: set proper mute state for audio/video tracks after reconnection #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set proper mute state for audio/video tracks after reconnection #963
Conversation
📝 WalkthroughWalkthroughPropagates the track's muted state to the server when adding audio and video tracks by using Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (3)
✏️ Tip: You can disable this entire section by setting Comment |
|
Nice!, thank you for your PR, I'll test this out. |
Closes #962
How does it fix that?
The methods
publishAudioTrackandpublishVideoTrackare called on call reconnection here -client-sdk-flutter/lib/src/participant/local.dart
Lines 560 to 570 in 70d4d1f
But inside the methods we're not passing the
mutedstate from the old tracks we have. It defaults tofalsebecause it's not set in protobuf:client-sdk-flutter/lib/src/proto/livekit_rtc.pb.dart
Line 1153 in 70d4d1f
By passing it correctly, this PR fixes the bug in the linked issue.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.