feat(langgraph): add custom stream mode support in LangChain LLMAdapter #4511
Conversation
Extend _to_chat_chunk to handle StreamWriter output types (dict, objects with content attr) so both "messages" and "custom" modes use the same conversion function. The difference is that "messages" mode data goes through _extract_message_chunk first to unwrap (token, meta) tuples, while "custom" mode data from StreamWriter is passed directly.")
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b0639d783
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
livekit-plugins/livekit-plugins-langchain/livekit/plugins/langchain/langgraph.py
Outdated
Show resolved
Hide resolved
- Expand StreamMode type to include all modes to satisfy type checker. - Add runtime validation to raise ValueError for unsupported modes
Add explicit handling for single-mode "custom"
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6eb8409988
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
livekit-plugins/livekit-plugins-langchain/livekit/plugins/langchain/langgraph.py
Show resolved
Hide resolved
|
@davidzhao I saw you’ve reviewed related pr #3112 before. |
keenranger
changed the title
2 participants
Langgraph not only supports messages streams but also custom. And it is only way to modify what to stream in livekit-langgraph integration.
So for that,
stream_modeparameter supporting"messages"and"custom"modes_to_chat_chunk()to handle dict and object inputs