[housekeeping] Integer-related compiler warnings #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address always false warning ([-Wtype-limits]):
../vip.c:430:15: warning: comparison of unsigned expression in ‘< 0’ is
always false [-Wtype-limits]
430 | if (n < 0) {
| ^
../vip.c:437:15: warning: comparison of unsigned expression in ‘< 0’
is always false [-Wtype-limits]
437 | if (n < 0) {
Signed-off-by: Igor Opaniuk <[email protected]>
Address warnings for comparisons of integer expressions of different
signedness, for example:
../firehose.c:384:31: warning: comparison of integer expressions of
different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
384 | for (i = 0; i < ARRAY_SIZE(sector_sizes); i++) {
In all places, where signed value is casted to unsigned (size_t for
instance), there is always explicitly handling of possible negative
value beforehand
Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
changed the title
igoropaniuk
commented
Nov 25, 2025
| } | ||
|
|
||
| if (n < qdl->max_payload_size) | ||
| if ((size_t)n < qdl->max_payload_size) |
Contributor
Author
There was a problem hiding this comment.
the check of n < 0 is above, so safe to cast here
igoropaniuk
commented
Nov 25, 2025
| } else if (expect_empty) { | ||
| err(1, "expected empty transfer but received non-empty transfer during read"); | ||
| } else if (n != chunk_size * sector_size) { | ||
| } else if ((size_t)n != chunk_size * sector_size) { |
Contributor
Author
There was a problem hiding this comment.
the check of n < 0 is above, so safe to cast here
igoropaniuk
commented
Nov 25, 2025
|
|
||
| if (out_buf) { | ||
| if (n > out_len - out_offset) | ||
| if ((size_t)n > out_len - out_offset) |
Contributor
Author
There was a problem hiding this comment.
the check of n < 0 is already above, so safe to cast here
igoropaniuk
commented
Nov 25, 2025
|
|
||
| pkt = (struct sahara_pkt *)buf; | ||
| if (n != pkt->length) { | ||
| if ((uint32_t)n != pkt->length) { |
Contributor
Author
There was a problem hiding this comment.
the check of n < 0 is already above, so safe to cast here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.