-
Notifications
You must be signed in to change notification settings - Fork 0
Add more ways for funnel publishing consumers registration #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more ways for funnel publishing consumers registration #82
Conversation
…rvicesBuilder overloads
Summary
🎉 No failed tests in this run. | ⏭️ No skipped tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 90.09% 90.31% +0.22%
==========================================
Files 34 34
Lines 747 764 +17
Branches 46 46
==========================================
+ Hits 673 690 +17
Misses 71 71
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the funnel publishing consumer registration API by adding convenient overload methods and enabling fluent method chaining. The changes allow developers to reuse topics already configured in a LeanPipe builder without duplicating configuration logic.
- Added two new overload methods for
AddFunnelledLeanPipeConsumersacceptingTypesCatalogandLeanPipeServicesBuilderparameters - Changed method return types from
voidto their respective interface types to enable fluent method chaining - Exposed the
Topicsproperty onLeanPipeServicesBuilderas public with a private setter
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| publisher/src/LeanCode.Pipe/Extensions/LeanPipeServiceCollectionExtensions.cs | Exposes the Topics property as public to enable access by new registration overloads |
| publisher/src/Funnel/Publishing/RegistrationConfiguratorExtensions.cs | Adds two new overloads for AddFunnelledLeanPipeConsumers accepting TypesCatalog and LeanPipeServicesBuilder, changes return type to IRegistrationConfigurator for fluent chaining |
| publisher/src/Funnel/Instance/ServiceCollectionExtensions.cs | Changes AddLeanPipeFunnel return type from void to IServiceCollection for fluent chaining |
| publisher/src/Funnel/Instance/RegistrationConfiguratorExtensions.cs | Changes ConfigureLeanPipeFunnelConsumers return type from void to IRegistrationConfigurator for fluent chaining |
| publisher/test/Funnel.Tests/LeanCode.Pipe.Funnel.Tests/Publishing/RegistrationConfiguratorExtensionsTests.cs | Adds test coverage for the two new overload methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to explain in the docstrings here when one might want to use each of those AddFunnelledLeanPipeConsumers overloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note that hints what is the default overload
Particularly useful when we already have proper topics configured in the leanpipe builder, and don't want to duplicate this logic while registering funnelled app topic consumers.