Skip to content

Conversation

@Dragemil
Copy link
Collaborator

@Dragemil Dragemil commented Jan 2, 2026

Particularly useful when we already have proper topics configured in the leanpipe builder, and don't want to duplicate this logic while registering funnelled app topic consumers.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 17.8s

🎉 No failed tests in this run. | ⏭️ No skipped tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (b59b298) to head (de64993).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   90.09%   90.31%   +0.22%     
==========================================
  Files          34       34              
  Lines         747      764      +17     
  Branches       46       46              
==========================================
+ Hits          673      690      +17     
  Misses         71       71              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the funnel publishing consumer registration API by adding convenient overload methods and enabling fluent method chaining. The changes allow developers to reuse topics already configured in a LeanPipe builder without duplicating configuration logic.

  • Added two new overload methods for AddFunnelledLeanPipeConsumers accepting TypesCatalog and LeanPipeServicesBuilder parameters
  • Changed method return types from void to their respective interface types to enable fluent method chaining
  • Exposed the Topics property on LeanPipeServicesBuilder as public with a private setter

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
publisher/src/LeanCode.Pipe/Extensions/LeanPipeServiceCollectionExtensions.cs Exposes the Topics property as public to enable access by new registration overloads
publisher/src/Funnel/Publishing/RegistrationConfiguratorExtensions.cs Adds two new overloads for AddFunnelledLeanPipeConsumers accepting TypesCatalog and LeanPipeServicesBuilder, changes return type to IRegistrationConfigurator for fluent chaining
publisher/src/Funnel/Instance/ServiceCollectionExtensions.cs Changes AddLeanPipeFunnel return type from void to IServiceCollection for fluent chaining
publisher/src/Funnel/Instance/RegistrationConfiguratorExtensions.cs Changes ConfigureLeanPipeFunnelConsumers return type from void to IRegistrationConfigurator for fluent chaining
publisher/test/Funnel.Tests/LeanCode.Pipe.Funnel.Tests/Publishing/RegistrationConfiguratorExtensionsTests.cs Adds test coverage for the two new overload methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to explain in the docstrings here when one might want to use each of those AddFunnelledLeanPipeConsumers overloads

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note that hints what is the default overload

@Dragemil Dragemil merged commit f52b3a2 into main Jan 7, 2026
5 checks passed
@Dragemil Dragemil deleted the feature/improve-funnel-publishing-consumers-registration branch January 7, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants