Skip to content

Conversation

@saurabhraghuvanshii
Copy link
Contributor

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: saurabhraghuvanshii <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 6, 2025

🚀 Preview for commit d99f282 at: https://6934a2be53d25589bc1117d7--layer5.netlify.app

@saurabhraghuvanshii saurabhraghuvanshii mentioned this pull request Dec 6, 2025
@leecalcote
Copy link
Member

  const pathname = locationProp?.pathname || (typeof window !== "undefined" ? window.location.pathname : "/");

Does this approach look just as well?

@saurabhraghuvanshii
Copy link
Contributor Author

  const pathname = locationProp?.pathname || (typeof window !== "undefined" ? window.location.pathname : "/");

Does this approach look just as well?

yeah this looks goods let's see result

leecalcote and others added 4 commits December 7, 2025 03:33
Replaced useLocation hook with window.location for pathname retrieval.

Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
@leecalcote
Copy link
Member

I don't know that this change is needed any longer, is it?

@l5io
Copy link
Contributor

l5io commented Dec 6, 2025

🚀 Preview for commit 15abf92 at: https://6934abf7cd2d76b01917389c--layer5.netlify.app

@saurabhraghuvanshii
Copy link
Contributor Author

still same issue

@leecalcote
Copy link
Member

We're still having a Footer issue even after the other PR was merged?

Signed-off-by: saurabhraghuvanshii <[email protected]>
@saurabhraghuvanshii
Copy link
Contributor Author

We're still having a Footer issue even after the other PR was merged?

Yes, I’m hoping this new commit fixes it.

@l5io
Copy link
Contributor

l5io commented Dec 6, 2025

🚀 Preview for commit 111b186 at: https://6934b25de62416acea8cc866--layer5.netlify.app

Signed-off-by: saurabhraghuvanshii <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 6, 2025

🚀 Preview for commit a5e0fd1 at: https://6934b750c7d983cb59ae8a58--layer5.netlify.app

@leecalcote
Copy link
Member

leecalcote commented Dec 7, 2025

I’m not convinced that these changes are needed. When and where are you seeing bugs pertaining to these changes?

@leecalcote leecalcote added the pr/hold Do not merge this PR label Dec 7, 2025
@saurabhraghuvanshii
Copy link
Contributor Author

closing this PR as it is out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/hold Do not merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants