-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: footer issue on build #7236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: saurabhraghuvanshii <[email protected]>
|
🚀 Preview for commit d99f282 at: https://6934a2be53d25589bc1117d7--layer5.netlify.app |
Does this approach look just as well? |
yeah this looks goods let's see result |
Replaced useLocation hook with window.location for pathname retrieval. Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: Saurabh Singh <[email protected]>
|
I don't know that this change is needed any longer, is it? |
|
🚀 Preview for commit 15abf92 at: https://6934abf7cd2d76b01917389c--layer5.netlify.app |
|
still same issue |
|
We're still having a Footer issue even after the other PR was merged? |
Signed-off-by: saurabhraghuvanshii <[email protected]>
Yes, I’m hoping this new commit fixes it. |
|
🚀 Preview for commit 111b186 at: https://6934b25de62416acea8cc866--layer5.netlify.app |
Signed-off-by: saurabhraghuvanshii <[email protected]>
|
🚀 Preview for commit a5e0fd1 at: https://6934b750c7d983cb59ae8a58--layer5.netlify.app |
|
I’m not convinced that these changes are needed. When and where are you seeing bugs pertaining to these changes? |
|
closing this PR as it is out of scope |
Description
This PR fixes #
Notes for Reviewers
Signed commits