Skip to content

Conversation

@achimnol
Copy link
Member

@achimnol achimnol commented Dec 13, 2025

resolves #7261 (BA-3336)

Let's apply PEP 508 environment markers to requirements.txt for platform-specific accelerator dependencies.

  • tt-smi (→ pyluwen): Explicitly mark it as Linux x86-64 only.
  • habana-pyhlml: It's a pure Python package that uses ctypes. No change is needed.

Checklist: (if applicable)

  • Mention to the original issue

@github-actions github-actions bot added size:M 30~100 LoC size:XS ~10 LoC and removed size:M 30~100 LoC labels Dec 13, 2025
@achimnol achimnol marked this pull request as ready for review December 13, 2025 16:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds PEP 508 environment markers to platform-specific accelerator dependencies to prevent installation failures on unsupported platforms. The main change restricts tt-smi (which depends on pyluwen, a Linux x86-64 binary) to only install on compatible platforms.

Key Changes:

  • Added platform-specific environment markers to tt-smi dependency restricting it to Linux x86-64
  • Updated module mapping in BUILD file to include additional tt-smi modules
  • Lock file automatically updated with patch versions and dependency hashes

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
requirements.txt Added PEP 508 environment marker to tt-smi dependency to restrict installation to Linux x86-64 platforms
python.lock Updated lock file reflecting the environment marker change and automatic patch version updates for various dependencies
changes/7262.fix.md Added changelog entry documenting the fix for platform-specific dependency markers
BUILD Extended module mapping for tt-smi to include tt_tools in addition to tt_smi

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Dec 18, 2025
@achimnol achimnol force-pushed the chore/make-accelerator-binary-deps-platform-specific branch from aaf2241 to cb983a6 Compare December 18, 2025 12:56
@HyeockJinKim HyeockJinKim force-pushed the main branch 2 times, most recently from 9552aac to 4af738e Compare December 31, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10~30 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make accelerator's platform-specific dependencies optional

2 participants